add name and symbol to the asset_data table #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is failing |
| let raw_name = asset_data.raw_name.clone(); | ||
| match String::from_utf8(raw_name) { | ||
| Ok(s) => Some(s), | ||
| Err(_) => Some(name.clone()), |
There was a problem hiding this comment.
Under what scenarios would this happen? Do you have an example NFT?
There was a problem hiding this comment.
It can fail if the utf8 check validation of the string fails. I don't have an example nft
| @@ -151,6 +151,35 @@ pub fn safe_select<'a>( | |||
| .and_then(|v| v.pop()) | |||
| } | |||
|
|
|||
| #[cfg(feature = "fetch-raw-fields")] | |||
| async fn process_raw_fields( | |||
There was a problem hiding this comment.
Right now, I am using it for testing purpose. Its disabled due the compile/build time flag. However, based on a new optional field in the api, we will extract the raw fields or the sanitised fields
Test was failing. Fixed it. |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.